[PATCH] D49667: [clangd] Tune down quality score for class constructors so that it's ranked after class types.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

No opinion on the boost style thing.



================
Comment at: unittests/clangd/QualityTests.cpp:198
   EXPECT_LT(Macro.evaluate(), Default.evaluate());
+  EXPECT_LT(Macro.evaluate(), Default.evaluate());
+  EXPECT_LT(Constructor.evaluate(), Function.evaluate());
----------------
duplicates previous line


================
Comment at: unittests/clangd/QualityTests.cpp:273
   });
-  SymbolRelevanceSignals Ctor;
-  Ctor.merge(CodeCompletionResult(CtorDecl, /*Priority=*/0));
-
-  EXPECT_EQ(Cls.Scope, SymbolRelevanceSignals::GlobalScope);
-  EXPECT_EQ(Ctor.Scope, SymbolRelevanceSignals::GlobalScope);
+  SymbolQualitySignals Q;
+  Q.merge(CodeCompletionResult(CtorDecl, /*Priority=*/0));
----------------
This looks like it duplicates part of the test below, and removes a sensible test for scopes on constructors?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49667