[PATCH] D49543: [clangd] Penalize non-instance members when accessed via class instances.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/Quality.cpp:146
+    return false;
+  if (const auto *CM = dyn_cast<CXXMethodDecl>(ND))
+    return !CM->isStatic();
----------------
sammccall wrote:
> I think we also have to consider template functions too?
> And ideally I think we want to exclude constructors (but include destructors).
Done for template functions. 

I'm not very sure whether constructors are instance members in general, but they should already be filtered out by sema in dot/arror member accessed.


Repository:
  rL LLVM

https://reviews.llvm.org/D49543