[PATCH] D49647: [libcxx] Library support for contracts (C++2a)

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Thanks for doing this, but it needs tests before it can land.
If I were to define `class contract_violation {};` that would pass the tests you've provided.
(Heck, if I removed the entire definition of `contract_violation`, it would still pass.)



================
Comment at: include/contract:41
+
+class contract_violation {
+public:
----------------
Needs `_LIBCPP_TYPE_VIS`


Repository:
  rCXX libc++

https://reviews.llvm.org/D49647