[PATCH] D49523: [clangd] Add support for per-file override compilation command

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

In https://reviews.llvm.org/D49523#1169743, @jkorous wrote:

> BTW it looks like we already had kind of support for compilation command before (extra flags).
>
> commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852
>  Author: Krasimir Georgiev <krasimir at google.com>
>  Date:   Thu Jul 6 08:44:54 2017 +0000
>
>   [clangd] Add support for per-file extra flags
>   
>
> There is even an LSP extension proposal:
>
> https://github.com/Microsoft/language-server-protocol/issues/255
>
> But it seems as if we lost access to it here:
>
> commit aa49372548ff984ae9c48879a0d05833538a76b3
>  Author: Sam McCall <sam.mccall at gmail.com>
>  Date:   Mon Dec 4 10:08:45 2017 +0000
>
>   [clangd] GlobalCompilationDatabase interface changes


The extra-flags are still supported, see the test for example. They're not a full compilation command, just extra flags.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49523