[PATCH] D49083: [HIP] Register/unregister device fat binary only once
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 19 19:55:21 PDT 2018
yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: lib/CodeGen/CGCUDANV.cpp:578
+ DtorBuilder.CreateStore(Zero, GpuBinaryAddr);
+ DtorBuilder.CreateBr(ExitBlock);
+ DtorBuilder.SetInsertPoint(ExitBlock);
----------------
rjmccall wrote:
> Don't just indent stuff if you're not putting it in a brace-statement. By "vertical space" I meant putting newlines between the emission of the different blocks.
sorry I misunderstood. will fix.
https://reviews.llvm.org/D49083
More information about the cfe-commits
mailing list