[PATCH] D49303: [CodeGen][ObjC] Treat non-escaping blocks as global blocks to make copy/dispose a no-op

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Thanks.  A couple tiny things and then LGTM.



================
Comment at: docs/Block-ABI-Apple.rst:69
+        // block is a no-op, which is exactly how global blocks are handled.
+
+        BLOCK_IS_NOESCAPE      =  (1 << 23),
----------------
Thanks, that looks good.  I think it's important to emphasize that setting `BLOCK_IS_GLOBAL` is necessary *for backward compatibility*, though.

You have a newline between the comment and BLOCK_IS_NOESCAPE that feels out-of-place.


Repository:
  rC Clang

https://reviews.llvm.org/D49303