[PATCH] D48412: [RISCV] Add support for interrupt attribute

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 19 06:58:57 PDT 2018


asb accepted this revision.
asb added a comment.
Herald added a subscriber: rkruppe.

This looks good to me with two caveats

- the tests don't seem to check that the "machine" is the default mode when the "interrupt" attribute has no arguments.
- Although the conversion from RISCVInterruptAttr::user to "user" etc is trivial, it would probably be worth testing the emitted attributes are as expected?


https://reviews.llvm.org/D48412





More information about the cfe-commits mailing list