[PATCH] D49476: [Index] Set OrigD before D is changed.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 19 01:25:35 PDT 2018
ioeric added a comment.
In https://reviews.llvm.org/D49476#1167294, @akyrtzi wrote:
> Is it possible to add a regression test case ? I assume this is fixing some issue, we should make sure we don't regress again.
This fixes a downstream use case where we use `OrigD`. AFAICT, `c-index-test` is used to tests the index library, but it doesn't seem to use `OrigD` at all. We could probably add a flag to `c-index-test` to optionally print out `OrigD`. I didn't go down this path because I thought this change is trivial and doesn't break any existing changes. If you think optionally checking `OrigD` is reasonable, I'd be happy to add that with a test case.
Repository:
rC Clang
https://reviews.llvm.org/D49476
More information about the cfe-commits
mailing list