[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D41938#1167313, @NoQ wrote:

> There are still performance regressions coming in, and this time it doesn't look like it's my fault: https://bugs.llvm.org/show_bug.cgi?id=38208
>
> I suspect that this might be because we aren't enforcing complexity thresholds over all the symbols we're constructing, but that's not certain, we need to get to the bottom of it some day.
>
> I suggest reverting the patch or putting it behind an off-by-default flag until we debug these cases.


The flag is off by default. Except the rearrangement of additive operations. Should we put it also behind the flag?


Repository:
  rL LLVM

https://reviews.llvm.org/D41938