[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 17 16:37:46 PDT 2018
Eugene.Zelenko added inline comments.
================
Comment at: test/clang-tidy/readability-magic-numbers.cpp:124
+
+ explicit Point(T xval, T yval) noexcept : x{xval}, y{yval} {
+ }
----------------
0x8000-0000 wrote:
> Eugene.Zelenko wrote:
> > Please run Clang-format over test case.
> I do run it constantly. In this case there is no change. I am using the clang-6.0 formatter though.
It's weird, since closing curly bracket should be in same line as opening. Also Rectangle constructor is longer then 80 symbols.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
More information about the cfe-commits
mailing list