[PATCH] D49083: [HIP] Register/unregister device fat binary only once

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 17 15:22:49 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGCUDANV.cpp:444
+    auto HandleValue =
+        CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign());
+    llvm::Constant *Zero = llvm::Constant::getNullValue(HandleValue->getType());
----------------
Do you not need to worry about concurrency here?


https://reviews.llvm.org/D49083





More information about the cfe-commits mailing list