[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 17 13:36:03 PDT 2018


Quuxplusone added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6425
+  "available on %2 %3 or newer">;
 def note_silence_unligned_allocation_unavailable : Note<
   "if you supply your own aligned allocation functions, use "
----------------
I observe that this mnemonic is misspelled; but that's not this patch's fault.
The traditional spelling would probably be just `note_aligned_allocation_unavailable`.


================
Comment at: lib/Driver/ToolChains/Darwin.cpp:2027
+      isAlignedAllocationUnavailable())
     CC1Args.push_back("-faligned-alloc-unavailable");
 }
----------------
Peanut gallery asks: Why is the cc1 option spelled differently from the clang driver option? Don't they do the same thing?


https://reviews.llvm.org/D45015





More information about the cfe-commits mailing list