[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added inline comments.


================
Comment at: include/charconv:372
+
+    auto __len = __last - __p;
+    if (__value != 0 || !__len)
----------------
mclow.lists wrote:
> Are you missing an edge case here? What happens if `__last == __first && __value == 0`?
> 
Nevermind. Apparently I can't look two lines down.


Repository:
  rCXX libc++

https://reviews.llvm.org/D41458