[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 16 04:04:42 PDT 2018


baloghadamsoftware added a comment.

In https://reviews.llvm.org/D49074#1160793, @NoQ wrote:

> I'd also rather stick to integer arithmetic and avoid using floats even in intermediate calculations. It'd be hard to make sure that no rounding errors kick in if we use floats.


Yes, I agree. I think an integer plus a flag (whether to take the reciprocal) is better since we only use n or 1/n for scaling.


https://reviews.llvm.org/D49074





More information about the cfe-commits mailing list