[PATCH] D48395: Added PublicOnly flag

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 16 01:20:32 PDT 2018


ioeric added a comment.

In https://reviews.llvm.org/D48395#1158869, @juliehockett wrote:

> Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric has any concerns.


No concern if this looks good to Julie.



================
Comment at: clang-tools-extra/test/clang-doc/yaml-module.cpp:14
+// CHECK-A: ---
+// CHECK-A-NEXT: USR:             '{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z]}}'
+// CHECK-A-NEXT: Name:            'moduleFunction'
----------------
This could be `[0-9A-Z]{N}` where N = length(USR), right?


https://reviews.llvm.org/D48395





More information about the cfe-commits mailing list