[PATCH] D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 16 00:46:29 PDT 2018


balazske added inline comments.


================
Comment at: lib/AST/ASTImporter.cpp:6741
+
+  auto *Ctor = dyn_cast<CXXConstructorDecl>(Importer.Import(
+      E->getConstructor()));
----------------
a_sidorin wrote:
> cast_or_null?
dyn_cast_or_null: Import may return nullptr, but if not, the cast should succeed (not a CXXConstructorDecl would be error).
Or (but some lines more code) check separately for null return from Import, and then use `cast`?


Repository:
  rC Clang

https://reviews.llvm.org/D49293





More information about the cfe-commits mailing list