[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

Zhihao Yuan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 9 14:27:23 PDT 2018


lichray added inline comments.


================
Comment at: test/support/charconv_test_helpers.h:24
+
+template <typename To, typename From>
+constexpr auto
----------------
mclow.lists wrote:
> If this is supposed to be a C++17 or later header (and I'm pretty sure it is), you should add a `static_assert(TEST_STD_VER > 14, "");` to this header.
> 
I can run it with `--param=std=c++11`.


Repository:
  rCXX libc++

https://reviews.llvm.org/D41458





More information about the cfe-commits mailing list