[PATCH] D49059: [MinGW] Skip adding default win32 api libraries if -lwindowsapp is specified

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 9 14:24:45 PDT 2018


smeenai added inline comments.


================
Comment at: test/Driver/mingw-windowsapp.c:5-6
+// CHECK_DEFAULT: "-lmsvcrt" "-ladvapi32" "-lshell32" "-luser32" "-lkernel32" "-lmingw32"
+// CHECK_WINDOWSAPP: "-lwindowsapp" "-lmingw32"
+// CHECK_WINDOWSAPP-SAME: "-lmsvcrt" "-lmingw32"
----------------
Why do we end up with -lmingw32 twice, and why not just check the full line, like you're doing for the default case?


Repository:
  rC Clang

https://reviews.llvm.org/D49059





More information about the cfe-commits mailing list