[PATCH] D48506: Fix for Crash in nested name specifier decltype

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington added a comment.

Hi Balaji, thanks for working on this!



================
Comment at: lib/Sema/SemaCXXScopeSpec.cpp:849-850
   QualType T = BuildDecltypeType(DS.getRepAsExpr(), DS.getTypeSpecTypeLoc());
+  if (T.getTypePtrOrNull() == nullptr)
+      return true;
   if (!T->isDependentType() && !T->getAs<TagType>()) {
----------------
T.isNull()? Also, we use 2 space indentation in LLVM.


================
Comment at: test/SemaCXX/qualtype-null-check.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s
+struct A
----------------
I can't reproduce this failure with TOT clang, are you sure you copied in the testcase right?


Repository:
  rC Clang

https://reviews.llvm.org/D48506