[PATCH] D48989: -fdebug-prefix-map option for cc1as

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

In https://reviews.llvm.org/D48989#1153957, @starsid wrote:

> In https://reviews.llvm.org/D48989#1153773, @compnerd wrote:
>
> > However, please add a test to ensure that the paths are mapped when invoking the assembler
>
>
> I added the tests to check the mapping logic through llvm-mc in https://reviews.llvm.org/D48988. In this revision, I merely test if the driver is passing the flags to cc1as. The only thing that is untested is if cc1as_main is setting the options in MCContext correctly. If you want to see a test for that, please can you guide me a little on an appropriate way to test this within tools/clang/test.


That would be more of an integration test, which we don't generally have in the 'lit' tests.  I think demonstrating correct mapping by llvm-mc is fine.

I have made a suggestion for the test in this patch, which helps show the option is being passed to cc1as as intended.



================
Comment at: test/Driver/debug-prefix-map.S:3
+
+// CHECK: fdebug-prefix-map=old=new
+
----------------
To show that the option is on the cc1as command line specifically:
CHECK: cc1as
CHECK-SAME: -fdebug-prefix-map=old=new



Repository:
  rC Clang

https://reviews.llvm.org/D48989