[PATCH] D49057: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 8 11:00:00 PDT 2018

xazax.hun added a comment.

Thanks! The changes look good, I forgot to mark one double lookup though in my previous review.

Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:121
+      if (State->contains<RawPtrMap>(ObjRegion)) {
+        NewSet = *State->get<RawPtrMap>(ObjRegion);
+        if (NewSet.contains(RawPtr.getAsSymbol()))
Oh, there is also a double lookup here, sorry I did not spot it in the initial review.


More information about the cfe-commits mailing list