[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: test/SemaObjC/property-in-class-extension-1.m:18
 
- at property (assign, readonly) NSString* changeMemoryModel; // expected-note {{property declared here}}
+ at property (unsafe_unretained, readonly) NSString* changeMemoryModel; // expected-note {{property declared here}}
 
----------------
QF5690 wrote:
> rjmccall wrote:
> > Whoa, why is this test case using `-Weverything`?  That seems unnecessarily fragile.
> Do you think it should be relaxed only to warnings that are appearing here?
Yeah, tests should generally only be testing specific categories.  Opt-out warnings are different, of course, but it's understood that adding a new opt-out warning is an ambitious change.


Repository:
  rC Clang

https://reviews.llvm.org/D44539