[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 6 18:54:35 PDT 2018

chandlerc resigned from this revision.
chandlerc added a comment.

I don't have any problem with this patch's code in theory but:

1. The question of whether this macro approach is better or worse than FreeBSD's or MUSL's seems a question for libc++ maintainers, not me.
2. The question of whether this is correct for NetBSD seems for the NetBSD maintainer.

Since the above folks are already on the list of reviewers, I'll bow out of this review.

Comment at: include/stddef.h:55
 // Re-use the compiler's <stddef.h> max_align_t where possible.
 #if !defined(__CLANG_MAX_ALIGN_T_DEFINED) && !defined(_GCC_MAX_ALIGN_T) && \
Unrelated to your patch, but this comment is now amazingly out of place.



More information about the cfe-commits mailing list