[PATCH] D49008: [clangd] Upgrade logging facilities with levels and formatv.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 6 05:57:12 PDT 2018
hokein added a comment.
The diff contains unrelated changes now.
Comment at: clangd/tool/ClangdMain.cpp:104
+ llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Info, "High level execution tracing"),
+ clEnumVal(Logger::Debug, "Low level details")),
> hokein wrote:
> > Is it intended not to expose `Verbose` mode?
> dlog is already controlled by -debug/-debug-only flag, so it seems it doesn't need a distinct level here too. WDYT?
> Renamed flag value to "verbose".
Yeah, vlog is controlled by debug flag. A flag "verbose" is more natural than `debug`.
rCTE Clang Tools Extra
More information about the cfe-commits