[PATCH] D49008: [clangd] Upgrade logging facilities with levels and formatv.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 6 05:28:10 PDT 2018

sammccall added inline comments.

Comment at: clangd/tool/ClangdMain.cpp:104
+    llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+                     clEnumVal(Logger::Info, "High level execution tracing"),
+                     clEnumVal(Logger::Debug, "Low level details")),
hokein wrote:
> Is it intended not to expose `Verbose` mode?
dlog is already controlled by -debug/-debug-only flag, so it seems it doesn't need a distinct level here too. WDYT?

Renamed flag value to "verbose".

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list