[PATCH] D49008: [clangd] Upgrade logging facilities with levels and formatv.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 6 03:27:47 PDT 2018

sammccall added a comment.

This borrows from https://reviews.llvm.org/D44226 (log levels) which got stalled for various reasons (@simark - is it OK if I pick this up?).
It doesn't actually split the LSP messages vs LSP message names into different levels, but that's a simple followup.

Switching to formatv seems like a nice ergonomic win while we're breaking interfaces.
It also in principle allows loggers to extract the format string and args separately (formatv doesn't yet provide APIs for this, but architecturally it's easy) which can help log analysis.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list