[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 5 17:29:27 PDT 2018

Quuxplusone added inline comments.

Comment at: libcxx/include/memory:1470
+        decltype(_VSTD::declval<_Alloc>().construct(_VSTD::declval<_Pointer>(),
+                                                    _VSTD::declval<_Args>())),
+        void
I think you should replace this `)))` with `)), void())` for absolute correctness (e.g. `construct` might plausibly return a pointer to the constructed object, and I think C++03 is okay with that).
Otherwise, awesome, this looks like what I'd expect. :)


More information about the cfe-commits mailing list