[PATCH] D48845: [Sema] Add fixit for unused lambda captures

Alexander Shaposhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 5 14:27:23 PDT 2018


alexshap added inline comments.


================
Comment at: lib/Sema/SemaLambda.cpp:1548
+      // Find the end of the explicit capture for use in fixits.
+      SourceLocation EndLoc;
+      if (From.isThisCapture() && From.isCopyCapture()) {
----------------
alexshap wrote:
> maybe these lines 1548 -1559 can be factored out into a helper function ?
+ maybe use a different name (EndLoc feels too generic in this particular case), but i don't insist


Repository:
  rC Clang

https://reviews.llvm.org/D48845





More information about the cfe-commits mailing list