[clang-tools-extra] r336320 - Revert "[clangd] FileDistance: temporarily disable in CodeComplete, it's behaving badly"
Sam McCall via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 5 01:26:54 PDT 2018
Author: sammccall
Date: Thu Jul 5 01:26:53 2018
New Revision: 336320
URL: http://llvm.org/viewvc/llvm-project?rev=336320&view=rev
Log:
Revert "[clangd] FileDistance: temporarily disable in CodeComplete, it's behaving badly"
The bad behavior seems to have been fixed by r336242 after all.
I thought it was persisting, but that was a different bug fixed by D48940
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/CodeComplete.cpp?rev=336320&r1=336319&r2=336320&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/CodeComplete.cpp (original)
+++ clang-tools-extra/trunk/clangd/CodeComplete.cpp Thu Jul 5 01:26:53 2018
@@ -1142,8 +1142,7 @@ private:
SymbolQualitySignals Quality;
SymbolRelevanceSignals Relevance;
Relevance.Query = SymbolRelevanceSignals::CodeComplete;
- // FIXME: re-enable this after working out why it eats memory.
- // Relevance.FileProximityMatch = FileProximity.getPointer();
+ Relevance.FileProximityMatch = FileProximity.getPointer();
auto &First = Bundle.front();
if (auto FuzzyScore = fuzzyScore(First))
Relevance.NameMatch = *FuzzyScore;
More information about the cfe-commits
mailing list