[PATCH] D48947: [clangd] Added a test for preambles and -isystem

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 5 01:08:00 PDT 2018

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

Comment at: unittests/clangd/ClangdTests.cpp:45
 namespace {
+// FIXME: This is copied from CodeCompleteTests.cpp. Share the code instead.
+MATCHER_P(Named, Name, "") { return arg.Name == Name; }
this is trivial enough that I wouldn't bother with the fixme.
You can also use ::testing::Field(&CodeCompletion::Name, "baz") directly

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list