[PATCH] D48943: [clangd] Do not write comments into Preamble PCH

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 5 01:01:05 PDT 2018

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Very nice!

Comment at: clangd/ClangdUnit.cpp:327
   CI.getFrontendOpts().SkipFunctionBodies = true;
+  // We don't want to write comments into PCH. They are racy and slow to read
+  // back. We rely on dynamic index for the comments instead.
nit: these are comment *locations* right?
(Relevant because if we were writing the actual comments, we may actually want this on!)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list