[PATCH] D48628: [AST] Structural equivalence of methods

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 5 00:16:01 PDT 2018

balazske marked an inline comment as done.
balazske added inline comments.

Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+  auto t = makeNamedDecls(
a_sidorin wrote:
> Could you add a comment why this test is disabled?
Methods are not checked, there was no decision about to include this check or not. The problem was related to performance overhead and if order-independent check of methods is needed. (ASTImporter should keep order of imported fields and methods.) (This test is about equivalence of `foo`.)

  rC Clang


More information about the cfe-commits mailing list