[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 18:23:01 PDT 2018

aaron.ballman closed this revision.
aaron.ballman added a comment.

In https://reviews.llvm.org/D44143#1152550, @boga95 wrote:

> How can I commit it?

You need to have obtained commit access first. I went ahead and committed on your behalf in r336301. Thank you for the patch!

Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:7
+This check flags all pseudo-random number engines, engine adaptor
+instantiations and `srand()` when initialized or seeded with default argument,
+constant expression or any user-configurable type. Pseudo-random number
boga95 wrote:
> aaron.ballman wrote:
> > Please add double backticks around `srand()` instead of single backticks.
> Should I use double backticks in release notes too?
Good catch; I'll add those when I commit.


More information about the cfe-commits mailing list