[PATCH] D48941: [ASTImporter] import FunctionDecl end locations

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 08:58:03 PDT 2018

martong added inline comments.

Comment at: lib/AST/ASTImporter.cpp:2559
+    ToFunction->setRangeEnd(Importer.Import(D->getLocEnd()));
   } else if (auto *FromConversion = dyn_cast<CXXConversionDecl>(D)) {
Why don't we need to call the `setRangeEnd()` when e.g. we create a `CXXMethodDecl` or a `CXXConversionDecl`? Couldn't we just call this after all these branches (at line 2587)?

  rC Clang


More information about the cfe-commits mailing list