[PATCH] D48942: [PCH] Add an option to not write comments into PCH

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 08:31:47 PDT 2018

ilya-biryukov added a comment.

Not sure about two things:

- Using PreprocessorOptions for plumbing this setting. I'd rather put it into FrontendOptions, but there seems to be no way to get those in the ASTWriter... Happy to search for the alternatives
- Lack of tests. I'm not sure how to properly test it in clang. I've added asserts in clangd, see the follow-up https://reviews.llvm.org/D48943. But happy to look into writing actual tests if that looks important.

Also not sure if someone else should look at this change, suggestions for reviewers are very welcome!

  rC Clang


More information about the cfe-commits mailing list