[PATCH] D48628: [AST] Structural equivalence of methods

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 03:25:23 PDT 2018


balazske added inline comments.


================
Comment at: lib/AST/ASTImporter.cpp:2454
+          if (IsStructuralMatch(D, FoundFunction)) {
+            const FunctionDecl *Definition = nullptr;
+            if (D->doesThisDeclarationHaveABody() &&
----------------
This change with `Definition` is needed to make the test ImportOfEquivalentMethod work. But this is a general problem with importing, I have a new test that fails and is not related to CXXMethodDecl. Add this new (not directly related) test or remove this change and disable the failing test?


Repository:
  rC Clang

https://reviews.llvm.org/D48628





More information about the cfe-commits mailing list