[PATCH] D48881: [clangd] Avoid collecting symbols from broken TUs in global-symbol-builder.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 02:25:29 PDT 2018

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a minor NIT

Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:88
+            (CI.getDiagnosticClient().getNumErrors() > 0)) {
+          llvm::errs() << "Found errors in the translation unit. Igoring "
+                          "collected symbols...\n";
NIT: Maybe use clangd's `log` here? To get timestamps in the output, etc.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list