[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

Petr Pavlu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 02:17:26 PDT 2018

petpav01 added inline comments.

Comment at: test/CodeGen/clang-sections-attribute.c:1
+// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s
chill wrote:
> Isn't it possible for the test to fail if the Arm target is not configured?
I think it should not be necessary to add a REQUIRES line because the test emits and checks only LLVM IR but no target codegen is done. An experiment without having the ARM target configured shows that the test still works in such a setting. Note also that the two already present tests for `#pragma clang section` (`clang-sections.cpp` and `clang-sections-tentative.c`) have a similar header as this new test as well.

  rC Clang


More information about the cfe-commits mailing list