[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 02:00:24 PDT 2018

hokein added subscribers: bkramer, hokein.
hokein added a comment.

I'm not familiar with this part of code, but the change looks fine to me. I think @bkramer is the right person to review it.

Please make sure the style align with LLVM code style.

Comment at: lib/Basic/VirtualFileSystem.cpp:507
 /// Adapt a InMemoryFile for VFS' File interface.
 class InMemoryFileAdaptor : public File {
I think we should have a comment saying the InMemoryFile has the same behavior as the real file system.

  rC Clang


More information about the cfe-commits mailing list