[PATCH] D48917: [SemaCodeComplete] Make sure visited contexts are passed to completion results handler.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 4 01:50:14 PDT 2018

ilya-biryukov added a comment.

Generally LG, just one comment.

Comment at: lib/Sema/SemaCodeComplete.cpp:3744
     AddMacroResults(PP, Results, false, PreferredTypeIsPointer);
-  HandleCodeCompleteResults(this, CodeCompleter, 
-                CodeCompletionContext(CodeCompletionContext::CCC_Expression, 
`ResultsBuilder`'s constructor accepts a `CodeCompletionContext`. Can we pass in the context with `PreferedType` there instead of reconstructing it later?
To make sure we don't miss other things (incl. any future additions) that `ResultsBuilder` puts into the context.

  rC Clang


More information about the cfe-commits mailing list