[PATCH] D48863: [Sema] Explain coroutine_traits template in diag

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 3 16:44:38 PDT 2018

rsmith added inline comments.

Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9051
 def err_implied_coroutine_type_not_found : Error<
   "%0 type was not found; include <experimental/coroutine> before defining "
   "a coroutine">;
Maybe we should also remove the "%0 type was not found; " here to avoid the suggestion that declaring that type yourself would be a reasonable way to solve the problem. (We don't say "std::type_info was not found" when a user uses `typeid` without a `#include <typeinfo>` and that doesn't seem to confuse anyone.) For symmetry with what we say for `typeid`, maybe this should be worded

  "you need to include <experimental/coroutine> before defining a coroutine"

  rC Clang


More information about the cfe-commits mailing list