[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

Simon Marchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 3 15:46:40 PDT 2018

simark added a comment.

An update, I traced the difference in behavior to the difference in how `RealFileSystem` and `InMemoryFileSystem` return `Status`es.

I uploaded a patch to change `InMemoryFileSystem` to work like `RealFileSystem`: https://reviews.llvm.org/D48903

With this patch applied on clang, it is now possible to write a test that reproduces the issue.  As @hokein said, if I keep the dynamic disabled, I get a single result with the ".." in it.  If I enable the dynamic index, I get two results, one with ".." and one without.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list