[PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 2 02:14:36 PDT 2018
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm.
Again, we might still want to measure the performance impact on files with potentially large #include tree ;)
================
Comment at: clangd/FileDistance.cpp:26
+// /bar/foo = 1
+// /foo = 1
+// /foo/bar = 2
----------------
Shouldn't /foo a down from / and `2+1 = 3`?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
More information about the cfe-commits
mailing list