[PATCH] D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 2 00:44:27 PDT 2018

klimek added inline comments.

Comment at: lib/Basic/VirtualFileSystem.cpp:328
 void OverlayFileSystem::pushOverlay(IntrusiveRefCntPtr<FileSystem> FS) {
+  // FIXME: OverlayFS containing another one in its stack could be flattened.
ilya-biryukov wrote:
> I generally agree that it might be useful, but given that we can't use `dynamic_cast` in LLVM code addressing this `FIXME` is probably not worth the effort.
> And this patch is probably not the right place to add this comment, since it doesn't change `OverlayFileSystem` in any way.
We can dyn_cast in LLVM code. It incurs some cost on the class hierarchy, but it's possible.


More information about the cfe-commits mailing list