[PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

[David Li via Phabricator via cfe-commits]

davidxl added inline comments.


================
Comment at: lib/profile/GCDAProfiling.c:546
+// find and call. In that case, it dumps profile data of a .so file.
+// If it is called directly inside a .so file, the unified copy of
+// llvm_gcov_flush might dump data of other .so file or the main module.
----------------
Just document this interface has non-hidden visibility and will resolve to a unified copy.   The right underlying behavior is for it to dump profiles from all dynamic modules, but it is not there until Marco's patch is in.

In other words, do not need to document the current behavior for now.


https://reviews.llvm.org/D45454