[PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

[Marco Castelluccio via Phabricator via cfe-commits]

marco-c added a comment.

OK! Sounds good to me to keep it hidden until
https://reviews.llvm.org/D48538 is done (I'm going to try to finish it
soon).

Il 29/06/2018 19:34, David Li via Phabricator ha scritto:

> davidxl added a comment.
> 
> With the current gcov_flush implementation in LLVM, making gcov_flush's visibility to be default will simply lead to wrong behavior.   GCC libgcov's implementation is more elaborate -- it allows gcov_flush to dump gcda data for all dynamic objects while making sure gcov_exit only dumps the gcda files from the same dynamic module (otherwise, there will be wrong profile merging). This is done via two levels of linked list.
> 
> The patch https://reviews.llvm.org/D48538 is in the right direction, but not complete yet.
> 
> https://reviews.llvm.org/D45454


https://reviews.llvm.org/D45454