[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 29 10:38:56 PDT 2018


arphaman added inline comments.


================
Comment at: lib/Sema/SemaDeclObjC.cpp:1208
+    // serialize something meaningful.
+    if (getLangOpts().Modules)
+      PushOnScopeChains(PDecl, TUScope);
----------------
Is this a problem only for modules or does this show up in PCHs too? What would be the cost of using PushOnScopeChains unconditionally?


Repository:
  rC Clang

https://reviews.llvm.org/D47297





More information about the cfe-commits mailing list