[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 29 05:58:54 PDT 2018
aaron.ballman added a comment.
In https://reviews.llvm.org/D48717#1147644, @JonasToth wrote:
> - fix decltype deduction with new matcher
>
> I had to introduce a new matcher in clang for `DecltypeType` to reach its underlying type. It would be better to have `hasType` resolve all these issues but i dont know how much work that would be.
I don't think we want to modify `hasType()` -- that would strip off too much type information if it automatically reached through to the underlying type. However, we may want to consider adding something like `hasUnderlyingType()` that checks the matcher against each level of type sugar. I'm not certain this would be required for your patch, however.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
More information about the cfe-commits
mailing list