[PATCH] D48762: [clangd] codeComplete returns more structured completion items, LSP. NFC.

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

LSP has some presentational fields with limited semantics (e.g. 'detail') and
doesn't provide a good place to return information like namespace.

Some places where more detailed information is useful:

- tools like quality analysis
- alternate frontends that aren't strictly LSP
- code completion unit tests

In this patch, ClangdServer::codeComplete still return LSP CompletionList, but
I plan to switch that soon (should be a no-op for ClangdLSPServer).

Deferring this makes it clear that we don't change behavior (tests stay the
same) and also keeps the API break to a small patch which can be reverted.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48762

Files:
  clangd/ClangdServer.cpp
  clangd/CodeComplete.cpp
  clangd/CodeComplete.h
  clangd/Protocol.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48762.153463.patch
Type: text/x-patch
Size: 25891 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180629/6b750e20/attachment-0001.bin>