[PATCH] D48721: Patch to fix pragma metadata for do-while loops
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 28 07:22:36 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D48721#1146681, @deepak2427 wrote:
> > Phab is the correct way to submit patches.
> > But having a bugreport in bugzilla is good too.
> > But the test will be needed regardless of the patch submission method.
> > And yes, please do always upload all patches with full context (`-U99999`).
>
> Sorry about the context.
> Can I add the test file to this patch itself? Or should that be another
> patch?
The test needs to be in `test/CodeGen/` (i'm guessing).
See other files there for examples.
(And do check that `$ ninja check-clang` passes)
https://reviews.llvm.org/D48721
More information about the cfe-commits
mailing list